Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The OracleJDK Dehaunting #353043

Merged
merged 6 commits into from
Nov 2, 2024

Conversation

tomodachi94
Copy link
Member

@tomodachi94 tomodachi94 commented Nov 2, 2024

"Unmaintained security disaster" -anonymous Nixpkgs maintainer

The Ghostbusters #jvm:nixos.org channel is coming to bust some ghosts old JDKs.

We dropped a few unsupported or unmaintained packages that happened to depend on OracleJDK.

Related: #313208

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 2, 2024
@tomodachi94 tomodachi94 added the 6.topic: java Including JDK, tooling, other languages, other VMs label Nov 2, 2024
Had a dependency on the Oracle JDK,
as well as being several years out-of-date.
@tomodachi94 tomodachi94 marked this pull request as draft November 2, 2024 02:58
@emilazy
Copy link
Member

emilazy commented Nov 2, 2024

@techknowlogick I see that you’ve made changes to the Atlassian packages recently – the NixOS module says that Atlassian only support the Oracle JDK, but reference a bug that appears to be related to some regex parsing issue of the java -version output? It seems like our OpenJDK packages should work fine with that, but also our Oracle JDK packages haven’t been updated since 2021(!!) and since they’re just builds of OpenJDK with a weird/bad licence, it seems like substituting our Nixpkgs‐built OpenJDKs should be fine. Just wanted to check that you think this should be fine, as I have no way of testing the modules.

@techknowlogick
Copy link
Member

@emilazy, thanks for the ping. I've since stopped using the Atlassian software suite, and I should probably rm my maintainership on those packages. TBH, I'd suggest making this switch as I'm not sure how much these are used with how few (see: none) reports came through for them being out of date, so if this PR breaks them, it might not have much impact.

@tomodachi94 tomodachi94 changed the title The OracleJDK Exorcism The OracleJDK Dehaunting Nov 2, 2024
@tomodachi94 tomodachi94 force-pushed the drop/oraclejdks-and-dependants branch 2 times, most recently from ae004bc to 6cd414e Compare November 2, 2024 04:38
@tomodachi94 tomodachi94 marked this pull request as ready for review November 2, 2024 04:43
@tomodachi94 tomodachi94 force-pushed the drop/oraclejdks-and-dependants branch 2 times, most recently from 724c263 to 4cd52ed Compare November 2, 2024 04:50
Upstream itself says it is not actively developed:
https://docear.org/2017/10/05/update-for-the-google-scholar-parser-library-to-fetch-metadata-for-pdf-files/

The sole Nixpkgs maintainer has not used Docear in
4 years:
NixOS#353043 (comment)
@tomodachi94 tomodachi94 force-pushed the drop/oraclejdks-and-dependants branch 2 times, most recently from ea1d94a to 224d1d5 Compare November 2, 2024 18:11
sqldeveloper was dropped due to being severely out-of-date and
having a dependency on JavaFX for Java 8, which we do not support.
Support for the Atlassian Server products ended in
February 2024 and there was insufficient interest in
maintaining the Atlassian Data Center replacements

c.f. NixOS#353043 (comment)
About to be removed, and this doesn't look true anymore.
"Unmaintained security disaster" -anonymous Nixpkgs maintainer
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 353043


x86_64-linux

⏩ 1 package blacklisted:
  • nixos-install-tools

Where did all the packages go? 😕

@emilazy emilazy merged commit 2b67faf into NixOS:master Nov 2, 2024
12 of 13 checks passed
@tomodachi94 tomodachi94 deleted the drop/oraclejdks-and-dependants branch November 2, 2024 21:15
Shawn8901 pushed a commit to Shawn8901/nixpkgs that referenced this pull request Nov 3, 2024
Upstream itself says it is not actively developed:
https://docear.org/2017/10/05/update-for-the-google-scholar-parser-library-to-fetch-metadata-for-pdf-files/

The sole Nixpkgs maintainer has not used Docear in
4 years:
NixOS#353043 (comment)
Shawn8901 pushed a commit to Shawn8901/nixpkgs that referenced this pull request Nov 3, 2024
Support for the Atlassian Server products ended in
February 2024 and there was insufficient interest in
maintaining the Atlassian Data Center replacements

c.f. NixOS#353043 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: java Including JDK, tooling, other languages, other VMs 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation 8.has: module (update) This PR changes an existing module in `nixos/`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants