llvmPackages.compiler_rt: Fix version tests for git #354471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without these fixes, the git build currently fails because the tests are out of date. One is updated since it was fixed upstream, the other is still needed for the git build, but testing `version` resulted in a test against the `unstable-*` string and not the one with the version number in it. Signed-off-by: Peter Waller <[email protected]>
github-actions
bot
added
the
6.topic: llvm/clang
pwaller
changed the title
ofborg
bot
requested review from
alyssais,
lovek323,
RossComputerGuy,
Ericson2314,
rrbutani,
sternenseemann and
dtzWill
|
|
pwaller
force-pushed
the
compiler-rt-fixes
branch
from
4ed1892
to
2c14728
Compare
ofborg
bot
added
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
and removed
10.rebuild-darwin-stdenv
|
ofborg confirms there are fewer rebuilds now. |
13 tasks
|
Result of 2 packages failed to build:
12 packages built:
|
|
|
these were broken a month or so ago and should be fixed now with the recent staging-next merge. |
|
Friendly one week ping. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without these fixes, the git build currently fails because the tests are
out of date.
One is updated since it was fixed upstream, the other is still needed
for the git build, but testing
versionresulted in a test against theunstable-*string and not the one with the version number in it.While we're here, switch --replace for --replace-fail to reduce the log warning(Edit: I've dropped this patch to avoid the giant darwin rebuild).spam.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.