ghostscript: fix installCheck on aarch64-darwin #355853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Result of 3 packages built:
|
|
Result of 2 packages failed to build:
3 packages built:
|
|
I take it this is only needed on 24.05? |
|
Yes. |
tobim
force-pushed
the
pkgs/ghostscript-darwin-installcheck
branch
from
94cc01c
to
229a8f7
Compare
emilazy
reviewed
Nov 16, 2024
Comment on lines
+152
to
+155
| preInstallCheck = if stdenv.hostPlatform.isDarwin then '' | ||
| DYLD_LIBRARY_PATH=$out/lib | ||
| export DYLD_LIBRARY_PATH | ||
| '' else null; |
There was a problem hiding this comment.
I believe this will still cause rebuilds (unless it defaults to null?). You generally need ${if stdenv.hostPlatform.isDarwin then "preInstallCheck" else null} = ….
There was a problem hiding this comment.
ofborg thinks it's fine.
ofborg
bot
added
10.rebuild-linux: 0
emilazy
approved these changes
Nov 17, 2024
|
Hello, I have the same problem building ghostscript but the provided fix allows building, but the resulting binary still fails. Am I doing something wrong? |
carlocab
added a commit
to carlocab/nixpkgs
that referenced
this pull request
Nov 22, 2024
Fixes NixOS#355377. This should avoid the need to mess around with `install_name_tool` entirely. This mirrors what is done by Homebrew[^1] and MacPorts[^2]. This should also make the changes in NixOS#355853 and NixOS#357951 unnecessary. [^1]: https://github.com/Homebrew/homebrew-core/blob/5ca4f8ce766c69d49321fb7da1d297b8232f40cf/Formula/g/ghostscript.rb#L76 [^2]: https://github.com/macports/macports-ports/blob/d8a05520fa6a81fa5b0365068590aff184976b69/print/ghostscript/Portfile#L114
13 tasks
|
This should fix it: #358079 |
emilazy
pushed a commit
that referenced
this pull request
Nov 25, 2024
Fixes #355377. This should avoid the need to mess around with `install_name_tool` entirely. This mirrors what is done by Homebrew[^1] and MacPorts[^2]. This should also make the changes in #355853 and #357951 unnecessary. [^1]: https://github.com/Homebrew/homebrew-core/blob/5ca4f8ce766c69d49321fb7da1d297b8232f40cf/Formula/g/ghostscript.rb#L76 [^2]: https://github.com/macports/macports-ports/blob/d8a05520fa6a81fa5b0365068590aff184976b69/print/ghostscript/Portfile#L114
osnyx
pushed a commit
to flyingcircusio/nixpkgs
that referenced
this pull request
Nov 25, 2024
Fixes NixOS#355377. This should avoid the need to mess around with `install_name_tool` entirely. This mirrors what is done by Homebrew[^1] and MacPorts[^2]. This should also make the changes in NixOS#355853 and NixOS#357951 unnecessary. [^1]: https://github.com/Homebrew/homebrew-core/blob/5ca4f8ce766c69d49321fb7da1d297b8232f40cf/Formula/g/ghostscript.rb#L76 [^2]: https://github.com/macports/macports-ports/blob/d8a05520fa6a81fa5b0365068590aff184976b69/print/ghostscript/Portfile#L114 (cherry picked from commit 8b3d3d5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #355377.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.