Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cyme: 1.8.4 -> 1.8.5 #356234

Merged
merged 1 commit into from
Dec 4, 2024
Merged

cyme: 1.8.4 -> 1.8.5 #356234

merged 1 commit into from
Dec 4, 2024

Conversation

kachick
Copy link
Member

@kachick kachick commented Nov 15, 2024

I have closed a PR which bumps to 2.x.

However, I still want to apply the latest v1.x patched version. tuna-f1sh/cyme@v1.8.4...v1.8.5

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@kachick
Copy link
Member Author

kachick commented Nov 15, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 356234


x86_64-linux

✅ 1 package built:
  • cyme

x86_64-darwin

✅ 1 package built:
  • cyme

aarch64-darwin

✅ 1 package built:
  • cyme

@kirillrdy
Copy link
Member

@kachick please consider adding link to changelog to commit message

https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#commit-conventions

if release doesn't have changelog, link to diff is sufficient

you can see examples

[kirillvr@tsutenkaku:~/nixpkgs]$ git log | grep Diff

@kachick kachick marked this pull request as draft December 2, 2024 07:49
@kachick
Copy link
Member Author

kachick commented Dec 2, 2024

Sorry for overlooking it. I only added it in the PR description and excluded it in the commit message. 🙇

@kachick kachick marked this pull request as ready for review December 2, 2024 08:16
@kachick
Copy link
Member Author

kachick commented Dec 4, 2024

Failed ofborg-eval-lib-tests — nix-build --arg pkgs import ./. {} ./lib/tests/release.nix from #354738, I'll rebase to avoid it.

@kirillrdy kirillrdy merged commit 6993346 into NixOS:master Dec 4, 2024
35 of 36 checks passed
@kachick
Copy link
Member Author

kachick commented Dec 5, 2024

Thanks!

@kachick kachick deleted the update-cyme-1.x branch December 5, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants