Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fcitx5-mozc: quickfix build #356590

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

boltzmannrain
Copy link
Contributor

@boltzmannrain boltzmannrain commented Nov 16, 2024

bazel_7 upgrade to 7.3.1+ had a regression breaking buildBazelPackage { bazel = bazel_7; }. See some discussion in #355723

fcitx5-mozc package should be currently buildable with bazel 6 #355723 (comment) Hopefully by the time it requires 7+ buildBazelPackage will be fixed

So let's downgrade bazel for now to 6.x for this package to unblock the 24.11 release

Should fix #355852

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

`bazel_7` upgrade to 7.3.1+ had a regression breaking `buildBazelPackage { bazel = bazel_7; }`.
See some discussion in NixOS#355723

`fcitx5-mozc` package should be currently buildable with bazel 6
NixOS#355723 (comment)
Hopefully by the time it requires 7+ `buildBazelPackage` will be fixed

So let's downgrade bazel for now to 6.x for this package to unblock the 24.11 release

Should fix NixOS#355852
This was referenced Nov 17, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Nov 17, 2024
@philiptaron
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 356590


x86_64-linux

✅ 2 packages built:
  • fcitx5-mozc
  • fcitx5-mozc-ut

@philiptaron philiptaron merged commit 2afd08e into NixOS:master Nov 17, 2024
39 of 40 checks passed
@osbm
Copy link

osbm commented Nov 21, 2024

Is this change will be in Nixos 24.11?

I know the actual release date is tomorrow and I am currently trying to update to 24.11 and got hit with:

error: builder for '/nix/store/j7r84gckajykldwv700z4m3j3gp9nvj8-bazel-7.4.0.drv' failed with exit code 1;
       last 10 log lines:
       > patching file src/main/java/com/google/devtools/build/lib/bazel/rules/BazelRuleClassProvider.java
       > Hunk #1 succeeded at 568 with fuzz 2 (offset 102 lines).
       > applying patch /nix/store/2y0fhjn87j7b22v3h8v5hxrmgbwmcn11-bazel_rc.patch
       > patching file src/main/cpp/option_processor.cc
       > applying patch /nix/store/9857sd4kzzpl1xcx81hwh98ldma58ya3-nix-hacks.patch
       > patching file src/main/java/com/google/devtools/build/lib/rules/repository/RepositoryDelegatorFunction.java
       > Hunk #1 FAILED at 178.
       > Hunk #2 succeeded at 634 (offset 24 lines).
       > 1 out of 2 hunks FAILED -- saving rejects to file src/main/java/com/google/devtools/build/lib/rules/repository/RepositoryDelegatorFunction.java.rej
       > patching file src/main/java/com/google/devtools/build/lib/shell/JavaSubprocessFactory.java
       For full logs, run 'nix log /nix/store/j7r84gckajykldwv700z4m3j3gp9nvj8-bazel-7.4.0.drv'.
error: 1 dependencies of derivation '/nix/store/vkzr7ymifkl2rwzzm59wxbm6q4bfv9mh-fcitx5-mozc-2.30.5544.102.drv' failed to build
error: 1 dependencies of derivation '/nix/store/gvq65946fawwhb415ggdr8k9sanl5d5f-fcitx5-with-addons-5.1.11.drv' failed to build
error: 1 dependencies of derivation '/nix/store/g60j4mdcn4mv9898cvaq1rir7n4jlmgi-set-environment.drv' failed to build
error: 1 dependencies of derivation '/nix/store/3f2pbwarpsxciflbmqcl8xprfkb60lac-system-path.drv' failed to build
error: 1 dependencies of derivation '/nix/store/6n8pdbnysgjsqc631pkc2dpp37wh160y-nixos-system-tartarus-b8b74b0.drv' failed to build

I am just curious. How can i resolve this issue? I resolved it by using unstable version of the fcitx5-mozc

@CHN-beta CHN-beta added the backport release-24.11 Backport PR automatically label Nov 25, 2024
Copy link
Contributor

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: fcitx5-mozc
4 participants