-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fcitx5-mozc: quickfix build #356590
Merged
Merged
fcitx5-mozc: quickfix build #356590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`bazel_7` upgrade to 7.3.1+ had a regression breaking `buildBazelPackage { bazel = bazel_7; }`. See some discussion in NixOS#355723 `fcitx5-mozc` package should be currently buildable with bazel 6 NixOS#355723 (comment) Hopefully by the time it requires 7+ `buildBazelPackage` will be fixed So let's downgrade bazel for now to 6.x for this package to unblock the 24.11 release Should fix NixOS#355852
This was referenced Nov 17, 2024
ofborg
bot
added
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 1-10
labels
Nov 17, 2024
|
philiptaron
approved these changes
Nov 17, 2024
Is this change will be in Nixos 24.11? I know the actual release date is tomorrow and I am currently trying to update to 24.11 and got hit with:
I am just curious. |
Successfully created backport PR for |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 1-10
backport release-24.11
Backport PR automatically
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bazel_7
upgrade to 7.3.1+ had a regression breakingbuildBazelPackage { bazel = bazel_7; }
. See some discussion in #355723fcitx5-mozc
package should be currently buildable with bazel 6 #355723 (comment) Hopefully by the time it requires 7+buildBazelPackage
will be fixedSo let's downgrade bazel for now to 6.x for this package to unblock the 24.11 release
Should fix #355852
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.