Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aactivator: init at 2.0.0 #357493

Merged
merged 2 commits into from
Nov 24, 2024
Merged

aactivator: init at 2.0.0 #357493

merged 2 commits into from
Nov 24, 2024

Conversation

keller00
Copy link
Contributor

aactivator automatically activate Python virtualenvs (and other environments).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Nov 20, 2024
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Nov 20, 2024
Copy link
Contributor

@aucub aucub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to nixpkgs! Please split adding maintainers and adding packages into two commits

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/aactivator/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/aactivator/default.nix Outdated Show resolved Hide resolved
pkgs/by-name/aa/aactivator/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/aa/aactivator/default.nix Outdated Show resolved Hide resolved
pkgs/by-name/aa/aactivator/default.nix Outdated Show resolved Hide resolved
@keller00
Copy link
Contributor Author

@aucub Is the normal workflow usually that people apply the suggestions manually and then force-push over their commits every time? Or is it possible to accept suggestions and not force-push over my old commits.
The commit guidelines do not make it sound like adding suggestion commits is encouraged.

Hopefully I got everything now!

@keller00 keller00 requested a review from aucub November 20, 2024 22:31
pkgs/by-name/aa/aactivator/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/aa/aactivator/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/aa/aactivator/package.nix Show resolved Hide resolved
@keller00 keller00 requested a review from aucub November 22, 2024 03:22
@ofborg ofborg bot added the ofborg-internal-error Ofborg encountered an error label Nov 22, 2024
@Aleksanaa Aleksanaa merged commit d6ae090 into NixOS:master Nov 24, 2024
40 of 41 checks passed
@keller00 keller00 deleted the add-aactivator branch November 24, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle! ofborg-internal-error Ofborg encountered an error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants