Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

q2pro: 3510 -> 0-unstable-2025-01-02 #357496

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

carlossless
Copy link
Contributor

@carlossless carlossless commented Nov 20, 2024

skullernet/q2pro@r3510...5b2d9f2

The r{xxxx} tags in upstream are not more significant than any other commits in master and shouldn't be considered as a form of releases - skullernet/q2pro#363 (comment). That's why the version is changed to 0-unstable-....

Additionally, I added an update script to ease and automate updates for this package.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@carlossless carlossless force-pushed the packages/q2pro branch 2 times, most recently from f130c1e to 4ee1e8a Compare November 20, 2024 08:51
@carlossless carlossless marked this pull request as ready for review November 20, 2024 10:21
@carlossless carlossless marked this pull request as draft November 20, 2024 20:11
@carlossless carlossless changed the title q2pro: 3510 -> 0-unstable-2024-11-19 q2pro: 3510 -> 3624 Nov 20, 2024
@keenanweaver
Copy link
Member

Could this be eligible for the unstable updater? https://github.com/NixOS/nixpkgs/blob/master/pkgs/common-updater/unstable-updater.nix Don't know the maintenance burden it would bring.

@carlossless
Copy link
Contributor Author

carlossless commented Nov 20, 2024

@keenanweaver I don't think so, not in its current state at least. The script would need to fetch the rev count (git rev-list --count ${src.rev}) to be in line with upstream builds.

This should be fairly doable with a custom script though, I would take a stab at it in a separate PR I added the script.

@carlossless carlossless marked this pull request as ready for review November 21, 2024 08:33
@carlossless carlossless force-pushed the packages/q2pro branch 2 times, most recently from ef69cd3 to e689154 Compare November 22, 2024 09:18
@carlossless carlossless changed the title q2pro: 3510 -> 3624 q2pro: 3510 -> 3626 Nov 22, 2024
@carlossless
Copy link
Contributor Author

carlossless commented Nov 22, 2024

The app icon currently appears broken on darwin, but that will be fixed separately with #358247

Copy link
Member

@keenanweaver keenanweaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Building & playing properly.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 25, 2024
@carlossless
Copy link
Contributor Author

The app icon currently appears broken on darwin, but that will be fixed separately with #358247

Rebased changes have this fixed now

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 28, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 4, 2025
@carlossless carlossless changed the title q2pro: 3510 -> 3626 q2pro: 3510 -> 0-unstable-2025-01-02 Jan 12, 2025
@carlossless
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 357496


x86_64-linux

✅ 1 package built:
  • q2pro

aarch64-linux

✅ 1 package built:
  • q2pro

x86_64-darwin

✅ 1 package built:
  • q2pro

aarch64-darwin

✅ 1 package built:
  • q2pro

@keenanweaver
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 357496


x86_64-linux

✅ 1 package built:
  • q2pro

@keenanweaver keenanweaver added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 12, 2025
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 12, 2025
@misuzu misuzu merged commit 733005c into NixOS:master Jan 15, 2025
49 of 52 checks passed
@carlossless carlossless deleted the packages/q2pro branch January 15, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants