-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
q2pro: 3510 -> 0-unstable-2025-01-02 #357496
Conversation
f130c1e
to
4ee1e8a
Compare
4ee1e8a
to
f147ba4
Compare
f147ba4
to
9ec236d
Compare
Could this be eligible for the unstable updater? https://github.com/NixOS/nixpkgs/blob/master/pkgs/common-updater/unstable-updater.nix Don't know the maintenance burden it would bring. |
@keenanweaver I don't think so, not in its current state at least. The script would need to fetch the rev count ( This should be fairly doable with a custom script though, |
9ec236d
to
80fc278
Compare
ef69cd3
to
e689154
Compare
e689154
to
d24acc7
Compare
The app icon currently appears broken on darwin, but that will be fixed separately with #358247 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Building & playing properly.
d24acc7
to
5ad6fc6
Compare
Rebased changes have this fixed now |
5ad6fc6
to
410c4e0
Compare
|
|
skullernet/q2pro@r3510...5b2d9f2
The r{xxxx} tags in upstream are not more significant than any other commits in master and shouldn't be considered as a form of releases - skullernet/q2pro#363 (comment). That's why the version is changed to
0-unstable-...
.Additionally, I added an update script to ease and automate updates for this package.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.