Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[24.11] duti: update to new darwin SDK pattern and add n-hass maintainer #358321

Open
wants to merge 2 commits into
base: release-24.11
Choose a base branch
from
Open

[24.11] duti: update to new darwin SDK pattern and add n-hass maintainer #358321

wants to merge 2 commits into from
+53 −13

Conversation

n-hass
Copy link
Contributor

@n-hass n-hass commented Nov 23, 2024 •
edited
Loading

Manual backport of #357745
(cherry picked from commit ed8e726)

and dependency #357747
(cherry picked from commit e226447)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@n-hass
duti: update to new darwin SDK pattern
5375a97 
remove old SDK, patch build configure checks

Signed-off-by: Nicholas Hassan <[email protected]>
(cherry picked from commit ed8e726)
@n-hass n-hass requested a review from emilazy November 23, 2024 05:21
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Nov 23, 2024
@n-hass
duti: add maintainer n-hass
a16362f 
(cherry picked from commit e226447)
@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Nov 24, 2024
@n-hass
Copy link
Contributor Author

n-hass commented Nov 24, 2024

ah sorry - fixed the missing maintainer info by cherry-picking #357747

@n-hass n-hass changed the title [24.11] duti: update to new darwin SDK pattern [24.11] duti: update to new darwin SDK pattern and add n-hass maintainer Nov 24, 2024
@ofborg ofborg bot requested a review from matthewbauer November 24, 2024 18:54
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilazy emilazy Awaiting requested review from emilazy

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@n-hass