Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alist: add update.nix #358335

Merged
merged 1 commit into from
Jan 28, 2025
Merged

alist: add update.nix #358335

merged 1 commit into from
Jan 28, 2025

Conversation

Moraxyc
Copy link
Contributor

@Moraxyc Moraxyc commented Nov 23, 2024

Add update.sh to bump version automatically.

https://github.com/AlistGo/alist/releases/tag/v3.40.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

pkgs/by-name/al/alist/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/al/alist/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/al/alist/update.sh Outdated Show resolved Hide resolved
pkgs/by-name/al/alist/update.nix Show resolved Hide resolved
pkgs/by-name/al/alist/update.nix Outdated Show resolved Hide resolved
pkgs/by-name/al/alist/update.nix Outdated Show resolved Hide resolved
pkgs/by-name/al/alist/update.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@jian-lin jian-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With these comments addressed, I think this PR is good to go.

pkgs/by-name/al/alist/update.nix Outdated Show resolved Hide resolved
pkgs/by-name/al/alist/update.nix Outdated Show resolved Hide resolved
pkgs/by-name/al/alist/update.nix Outdated Show resolved Hide resolved
@Moraxyc Moraxyc marked this pull request as draft November 24, 2024 09:14
@Moraxyc

This comment was marked as outdated.

@Moraxyc Moraxyc changed the title alist: add update.sh; 3.39.2 -> 3.40.0 alist: add update.nix Dec 5, 2024
@Moraxyc

This comment was marked as outdated.

@Moraxyc Moraxyc marked this pull request as ready for review December 5, 2024 08:56
@github-actions github-actions bot added the 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux label Dec 5, 2024
@jian-lin jian-lin dismissed their stale review December 5, 2024 11:15

outdated

Copy link
Contributor

@jian-lin jian-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jian-lin jian-lin merged commit bf97db9 into NixOS:master Jan 28, 2025
25 of 27 checks passed
@Moraxyc Moraxyc deleted the update-alist branch January 28, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants