Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scrcpy: 2.7 -> 3.0 #358820

Merged
merged 1 commit into from
Nov 26, 2024
Merged

scrcpy: 2.7 -> 3.0 #358820

merged 1 commit into from
Nov 26, 2024

Conversation

ryand56
Copy link
Member

@ryand56 ryand56 commented Nov 24, 2024 •
edited
Loading

https://github.com/Genymobile/scrcpy/releases/tag/v3.0
Diff: Genymobile/scrcpy@v2.7...v3.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ryand56 ryand56 marked this pull request as ready for review November 24, 2024 21:59
@ryand56
Copy link
Member Author

ryand56 commented Nov 24, 2024 •
edited
Loading

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 358820

x86_64-linux

✅ 2 packages built:
  • qtscrcpy
  • scrcpy

@ryand56 ryand56 added backport release-24.11 Backport PR automatically 11.by: package-maintainer This PR was created by the maintainer of the package it changes labels Nov 24, 2024
@ofborg ofborg bot requested a review from DeltaEvo November 25, 2024 15:00
@donovanglover donovanglover added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 25, 2024
@ryand56 ryand56 mentioned this pull request Nov 25, 2024
Closed
13 tasks
@lafrenierejm
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 358820

aarch64-darwin

✅ 1 package built:
  • scrcpy

@ryand56 ryand56 added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Nov 25, 2024
@donovanglover donovanglover merged commit cbdb3a0 into NixOS:master Nov 26, 2024
47 of 48 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-24.11:

@github-actions github-actions bot mentioned this pull request Nov 26, 2024
Merged
1 task
@ryand56 ryand56 deleted the update/scrcpy branch November 26, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donovanglover donovanglover donovanglover approved these changes

@lafrenierejm lafrenierejm lafrenierejm approved these changes

@DeltaEvo DeltaEvo Awaiting requested review from DeltaEvo

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryand56 @lafrenierejm @donovanglover