Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[24.05] litecoin{,d}: mark as vulnerable #358869

Merged
merged 1 commit into from
Nov 25, 2024
Merged

[24.05] litecoin{,d}: mark as vulnerable #358869

merged 1 commit into from
Nov 25, 2024

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented Nov 25, 2024

See #358865.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@emilazy emilazy added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Nov 25, 2024
@nix-owners nix-owners bot requested review from mmahut and RaghavSood November 25, 2024 02:20
tomodachi94
tomodachi94 approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@tomodachi94 tomodachi94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@tomodachi94 tomodachi94 merged commit ea4ade4 into NixOS:release-24.05 Nov 25, 2024
10 of 11 checks passed
@emilazy emilazy deleted the push-nvmptzkupypv branch November 25, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomodachi94 tomodachi94 tomodachi94 approved these changes

@mmahut mmahut Awaiting requested review from mmahut

@RaghavSood RaghavSood Awaiting requested review from RaghavSood

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilazy @tomodachi94