-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
obs-studio: 30.2.3 -> 31.0.1 #369193
obs-studio: 30.2.3 -> 31.0.1 #369193
Conversation
Have you tested browser sources? For me, trying to add a browser source to the scene freezes the dialog window. Maybe we need to bump cef? |
Hrm, I tested it on my x86-64 box and browser sources worked fine, although I didn't add a new one or try to open its settings - maybe that's the issue. I'll take a look. |
Another issue I just discovered is that there doesn't seem to be WHIP/WebRTC support. I'll investigate. |
Browser sources still work fine for me (my output path is /nix/store/jaw30w2bh6jc52vvxk5bkkzgbbwhm02x-obs-studio-31.0.0, and the drv is WHIP is indeed missing. |
https://github.com/obsproject/obs-studio/blob/a0e4e3734126a7e76a871fa671be952de5c13dd8/CMakePresets.json#L75-L78 the ubuntu preset sets ENABLE_WEBRTC false, for whatever reason... |
On /nix/store/4vv6m7p0smvj17galaa3pibd6l3ix583-obs-studio-31.0.0 (from That said... it does seem to start making OBS consume 100% CPU if I add a browser source, even if I then remove it. It doesn't happen with 30.2.3, though, even with the new build system. I bumped libcef to 127.0.6533.120 (since OBS 31.0 apparently is using 127.0.6533), but it still does it. It might be obsproject/obs-studio#11485, or thereabouts. |
OK, dropping obsproject/obs-browser@98d94a4 avoids the CPU spike but then reintroduces the problem with keyboard inputs causing OBS to crash in custom browser docks (which... are only enabled under X11, which confused me for a bit while trying to work out why the menu options don't show up on Wayland). |
I can confirm that WHIP is working now, thanks! However, no matter what I try from your comments, my OBS unfortunately keeps hanging when I try to add a browser source or add a browser dock. 🫤 |
Since you're already touching the libcef related parts in this PR, could we maybe also get an overridable flag to disable the browser? Given that the entire obs-studio closure is 3.6 GiB in size and 1.8 GiB of those are libcef which some people probably aren't even using it would be nice to be able to optionally get rid of it (most I mean.… my entire desktop system has a closure size of around 11 GiB, and 10% of those are libcef just because of obs-studio which doesn't sit right with me (and my Hydra is throwing diskspace warnings at me). |
JFYI, v31.0.1 released (https://github.com/obsproject/obs-studio/releases/tag/31.0.1) |
They would like builders to use CMake presets now; we inherit from their Ubuntu and macOS presets respectively.
Since browser sources don't work for me either on 30.2.3 nor 31.0.x without bringing in #317589, I think we can go ahead an merge this with browser support disabled for now. |
nvidia nvenc support seems to also be missing from this release as mentioned in #382666 |
This is a bump for OBS Studio from 30 to 31, which is a little bit more involved than most. There is a change from the "old" build system to a newer build system, which is still CMake-based but has been reworked to make use of the CMake presets system.
There are a few patches we (seem to) no longer need, so they've been dropped, but I haven't had a chance to test how this goes on macOS.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.