sonic-visualiser: use propagated build inputs #370573
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With nixpkgs switching to gcc 14 in stdenv recently, the newly enabled- by-default `-Wincompatible-pointer-types` causes a build failure for `sonic-visualiser`. This is due to a dependency on an outdated `librdf_raptor` instead of the current `librdf_raptor`. This patch removes the explicit dependency on `librdf_raptor` and `librdf_rasqal` in favor of propagated build inputs from `redland`.
github-actions
bot
added
10.rebuild-darwin: 0
|
@emilazy Here you go 😉 |
emilazy
approved these changes
Jan 3, 2025
There was a problem hiding this comment.
Looks good, thanks! The only remaining user of librdf_raptoris Ardour 6 which is supposed to be able to use Raptor 2 as well, even if it’s currently broken, right? I think we could unpin it there and remove the package entirely after this.
This package is on an outdated version and it seems like for some years now it’s mainly been getting sporadic bumps and adjustments from people handling compiler upgrade or dependency issues rather than caring about the software itself. I wonder if we should consider removing it; @MarcWeber @orivej-nixos are you still interested in maintaining this package?
wegank
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With nixpkgs switching to gcc 14 in stdenv recently, the newly enabled- by-default
-Wincompatible-pointer-typescauses a build failure forsonic-visualiser. This is due to a dependency on an outdatedlibrdf_raptorinstead of the currentlibrdf_raptor.This patch removes the explicit dependency on
librdf_raptorandlibrdf_rasqalin favor of propagated build inputs fromredland.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixpkgs-reviewresultGenerated using
nixpkgs-review.Command:
nixpkgs-reviewx86_64-linux✅ 1 package built:
Add a 👍 reaction to pull requests you find important.