Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apache-airflow: init at 1.9.0 #44028

Closed
wants to merge 1 commit into from

Conversation

offlinehacker
Copy link
Contributor

No description provided.

ryantm
ryantm previously requested changes Sep 9, 2018
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please resolve merge conflict so we can try building it.

@offlinehacker offlinehacker force-pushed the pkgs/airflow/init branch 2 times, most recently from a9fd375 to 2f8ef7c Compare October 14, 2018 08:58
@offlinehacker
Copy link
Contributor Author

@GrahamcOfBorg build airflow

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: airflow

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/w4xqg3wivkvwfvi61q4brd9kr5wd8xcf-python2.7-python2.7-apache-airflow-1.9.0
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/w4xqg3wivkvwfvi61q4brd9kr5wd8xcf-python2.7-python2.7-apache-airflow-1.9.0/lib  /nix/store/w4xqg3wivkvwfvi61q4brd9kr5wd8xcf-python2.7-python2.7-apache-airflow-1.9.0/bin
patching script interpreter paths in /nix/store/w4xqg3wivkvwfvi61q4brd9kr5wd8xcf-python2.7-python2.7-apache-airflow-1.9.0
/nix/store/w4xqg3wivkvwfvi61q4brd9kr5wd8xcf-python2.7-python2.7-apache-airflow-1.9.0/lib/python2.7/site-packages/airflow/bin/airflow: interpreter directive changed from "/usr/bin/env python" to "/nix/store/zsrsxd6mi3i2axy9a4w2cl643rardimz-python-2.7.15/bin/python"
checking for references to /build in /nix/store/w4xqg3wivkvwfvi61q4brd9kr5wd8xcf-python2.7-python2.7-apache-airflow-1.9.0...
wrapping `/nix/store/w4xqg3wivkvwfvi61q4brd9kr5wd8xcf-python2.7-python2.7-apache-airflow-1.9.0/bin/airflow'...
wrapping `/nix/store/w4xqg3wivkvwfvi61q4brd9kr5wd8xcf-python2.7-python2.7-apache-airflow-1.9.0/bin/.airflow-wrapped'...
/nix/store/w4xqg3wivkvwfvi61q4brd9kr5wd8xcf-python2.7-python2.7-apache-airflow-1.9.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: airflow

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/jr2c41v2gma6r4c3svcxyk8k6lswsliv-python2.7-python2.7-apache-airflow-1.9.0
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/jr2c41v2gma6r4c3svcxyk8k6lswsliv-python2.7-python2.7-apache-airflow-1.9.0/lib  /nix/store/jr2c41v2gma6r4c3svcxyk8k6lswsliv-python2.7-python2.7-apache-airflow-1.9.0/bin
patching script interpreter paths in /nix/store/jr2c41v2gma6r4c3svcxyk8k6lswsliv-python2.7-python2.7-apache-airflow-1.9.0
/nix/store/jr2c41v2gma6r4c3svcxyk8k6lswsliv-python2.7-python2.7-apache-airflow-1.9.0/lib/python2.7/site-packages/airflow/bin/airflow: interpreter directive changed from "/usr/bin/env python" to "/nix/store/zc814x9qlrfijn3pk176yrk0qcxpwqpc-python-2.7.15/bin/python"
checking for references to /build in /nix/store/jr2c41v2gma6r4c3svcxyk8k6lswsliv-python2.7-python2.7-apache-airflow-1.9.0...
wrapping `/nix/store/jr2c41v2gma6r4c3svcxyk8k6lswsliv-python2.7-python2.7-apache-airflow-1.9.0/bin/airflow'...
wrapping `/nix/store/jr2c41v2gma6r4c3svcxyk8k6lswsliv-python2.7-python2.7-apache-airflow-1.9.0/bin/.airflow-wrapped'...
/nix/store/jr2c41v2gma6r4c3svcxyk8k6lswsliv-python2.7-python2.7-apache-airflow-1.9.0

@samueldr samueldr dismissed ryantm’s stale review November 12, 2018 00:29

Merge conflict resolved

@samueldr
Copy link
Member

It built locally. Not sure what's usually done for pypi2nix packages, there seems to be only one other (gdbgui). The other one defines more fields for meta in its default.nix, though it looks like here everything is accounted for. Maybe @FRidh, @Mic92 or @garbas know more about adding pypi2nix packages in nix.

@cawilliamson
Copy link
Member

cawilliamson commented Jan 17, 2019

I'd love to see this merged - it's certainly been waiting long enough! 👍

Off topic but: @offlinehacker Until this gets merged, do you have an overlay for the latest airflow version at all? 👍

@Mic92
Copy link
Member

Mic92 commented Jan 24, 2019

Adding 3k lines to the nixpkgs repo is not so nice so.
@cawilliamson you can also add it to NUR.

@cawilliamson
Copy link
Member

@Mic92 It's not my commit - I'm just raising the question since it seems to have gone silent for a while.

As for not adding 3k lines - I do kinda get your point there but how else could you really package this for Nix?

@Mic92
Copy link
Member

Mic92 commented Jan 24, 2019

The alternative is to re-use packages from pkgs/top-level/python-packages.nix

@offlinehacker
Copy link
Contributor Author

Good luck with that and airflow, but yeah i agree this needs a better solution, but currently we don't have one for these cases in nixpkgs as everything is one giant monorepo, which has it's benefits, but also a lot of drawbacks.

@offlinehacker
Copy link
Contributor Author

I'm pretty much annoyed that all nixos, lib and pkgs are in one repo, as i have nix code that does not have anything to do with nixpkgs or nixos and i still have to use this repo.

@costrouc
Copy link
Member

I will create a formal package for Apache airflow without pip2nix. Should have this soon as a PR

@offlinehacker
Copy link
Contributor Author

@costrouc nice, what method are you using?

@costrouc
Copy link
Member

I've written a tool that creates the default.nix and does about 90% of the work. You can use it via "nix-shell -p nixpkgs --run "python-package-init airflow" for example. It makes the creation of theae

@rasendubi
Copy link
Member

#73074 adds apach-airflow-1.10.5 and has been merged, so I close this.

@rasendubi rasendubi closed this Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants