add update method to target_transforms #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the
updatemethod to the target transformations which will be used when callingTimeSeries.updateto apply the transformations to new values. Currently onlyDifferencesactually updates its stored values, since the impact of not doing it would be greater than for the scalers (so the scalers only transform the new values and keep their original parameters).The
updatemethod isn't declared as abstract in theBaseTargetTransformclass in order to not make this a breaking change. If someone wants to use a custom target transformation withTimeSeries.updatethey should define the update method, otherwise aNotImplementedErrorwill be raised.Fixes #292
Checklist: