Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add weight_col to MLForecast.fit and MLForecast.cross_validation #444

Merged
merged 4 commits into from
Nov 11, 2024
Merged

feat: add weight_col to MLForecast.fit and MLForecast.cross_validation #444

merged 4 commits into from
Nov 11, 2024

Conversation

jmoralez
Copy link
Member

@jmoralez jmoralez commented Nov 7, 2024 •
edited
Loading

  • Adds the weight_col argument to fit and cross validation.
  • Adds a small guide.
  • Changes the custom training guide to do something more exotic than setting sample weights.

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 8, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #444 will not alter performance

Comparing weight-col (8eabb75) with main (3edd9df)

Summary

✅ 12 untouched benchmarks

@jmoralez jmoralez marked this pull request as ready for review November 8, 2024 20:13
@jmoralez jmoralez merged commit 2164ce4 into main Nov 11, 2024
23 checks passed
@jmoralez jmoralez deleted the weight-col branch November 11, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jmoralez