Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Minor bugs #1158

Merged
merged 5 commits into from
Oct 1, 2024
Merged

[FIX] Minor bugs #1158

merged 5 commits into from
Oct 1, 2024

Conversation

elephaint
Copy link
Contributor

@elephaint elephaint commented Sep 26, 2024

As #1023 is getting out of hand, splitting up the pieces.

  • Replaces .item() in favor of .detach().item()
  • Increase dof in Student-t to 3 to improve stability
  • Improve speed of _divide_no_nan
  • Remove StemGNN from multivariate evaluation in CI, it's horribly slow.
  • Pad floats not int in ConstantPad1D (this errors when trying to compile a model)

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@elephaint elephaint changed the title [FIX} Minor bugs [FIX] Minor bugs Sep 26, 2024
@jmoralez
Copy link
Member

The purpose of .item() is converting a single element tensor to a python scalar. I'm guessing detach here is used to ensure the async execution of the GPU isn't blocked by that call, but wouldn't it be better to just prepend the detach call and keep the item? i.e. Tensor.detach().item()?

@elephaint
Copy link
Contributor Author

The purpose of .item() is converting a single element tensor to a python scalar. I'm guessing detach here is used to ensure the async execution of the GPU isn't blocked by that call, but wouldn't it be better to just prepend the detach call and keep the item? i.e. Tensor.detach().item()?

Yeah you're right, I was lazy here, since the scalar didn't seem strictly necessary to create the log I dropped it, but happy to add it back

@elephaint elephaint enabled auto-merge (squash) October 1, 2024 06:33
@elephaint elephaint merged commit 8d378c6 into main Oct 1, 2024
16 of 18 checks passed
@elephaint elephaint deleted the fix/small_bugs branch October 1, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants