-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
display nests on map #274
base: develop
Are you sure you want to change the base?
display nests on map #274
Conversation
change spawnpoints by top pokemon allow filtering by pokemon
How does this work? I installed it, but I do not see a /nest or any extra preferences, etc... nothing in /report either. Edit: Ok I see.. if you click the spawn layer, it then shows some pokemon. It doesn't have all the known frequent spawn point mons, but after looking at your code I see that it uses my pokemon layer and the only way to get everything to show up I need to select everything and then refresh the map. Ill have to change how I do things, but it looks like it works. Thanks! Edit2: The /nest idea is great so that way I do not have to mess with my map filters and can have different filters there potentially... |
Thanks for the feedback. I agree with the edits needed, it was more a quick PR push to help people identifying nests, we definitively need something better before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, caching would be good too here, as I for e.g. have 30m rows in my database so this would more or less kill my system
and even with a limit of 2 Weeks (time between two spawn migrations) I still have 8m rows
from ( | ||
select sightings.spawn_id, spawnpoints.despawn_time, spawnpoints.lat, spawnpoints.lon, spawnpoints.duration, sightings.pokemon_id, count(pokemon_id) as number | ||
from sightings, spawnpoints | ||
where sightings.spawn_id = spawnpoints.spawn_id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
think you should add a limit for the time too, as nests are only valid since the last (soft) migration
change spawnpoints by top pokemon
allow filtering by pokemon
should be used in a private panel instead of public raw map ... to avoid db to be killed with sql requests
creating a /nest will also allow to use different filters than main map