Fix bug in ENCOUNTER = 'some' #330
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Included ENCOUNTER = ‘some’ flag when NOTIFY = True and ALWAYS_NOTIFY_IDS is populated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Included ENCOUNTER = ‘some’ flag when NOTIFY = True and
ALWAYS_NOTIFY_IDS is populated.
-Without this check, everything in ALWAYS_NOTIFY_IDS will be encountered.
-This will allow you to use ENCOUNTER_IDS = { 201 } to just encounter Unown, but still allow you to send notifications in the ALWAYS_NOTIFY_IDS list.
-Tested using encounter to show gender and display results in PokeAlarm. Used Pidgey and Ekans to test, encountering Pidgey in the ENCOUNTER_IDS = {} to show gender, and Pidgey and Ekans in the ALWAYS_NOTIFY_IDS = {} list. Result would show Pidgey with gender and Ekans with ?.
-Also tested using my own live fork which now displays Unown form correctly.