Redesign crates, add Azure support #79
Conversation
auguwu
added
documentation
…geService::normalize
There was a problem hiding this comment.
This is an extremely large pull request, so I can't quite do an in-depth review! However, from looking at the general scope of changes, this seems like a promising direction - and certainly assists with moving a lot of the AWS S3 SDK specific things out!
I left only quick comments asking to please make TODOs in source also become GitHub issues - would appreciate your insight!
| // in CI (GitHub Actions), it will pull the `azurite` image as a Windows container and Microsoft | ||
| // doesn't ship Windows containers of the `azurite` image, so we just ignore the test alltogether | ||
| // | ||
| // TODO(@auguwu): how to fix this? :3 |
There was a problem hiding this comment.
Would it be possible to split this out into a separate issue?
| stream.write_all(&options.data[..]).await?; | ||
| stream.close().await | ||
|
|
||
| // TODO(@auguwu): add metadata to document that was created and the given content type |
There was a problem hiding this comment.
Similarly, can this be split out into its own issue?
I'll make marked |
The library I wanted to use is not what I had planned in mind of designing the `remi-gcs` crate. There can be a community maintained one or when people request Google Cloud Storage support, then we'll talk about it via issues.
auguwu
changed the title
|
I decided to not work on |
This crate does a whole lot of re-designing for the long run.
remi_coreasremishould serve the same purposeStrings or&[u8]to use an impl ofInto<T>.mut selfinstead of&mut self.This crate also adds experimental support for Azure Blob Storage via
azure_blob_storagecrate and Google Cloud Storage viagoogle-cloud-storagecrate.