refactor: Enhance readability of verify_transaction function

NoirHQ · Jan 3, 2025 · 8562bb2 · 8562bb2
1 parent 9cf4a5a
commit 8562bb2
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/frame/solana/runtime/src/transaction.rs b/frame/solana/runtime/src/transaction.rs
@@ -32,14 +32,13 @@ fn verify_transaction(
 	transaction: &SanitizedTransaction,
 	feature_set: &FeatureSet,
 ) -> Result<(), Error> {
-	#[allow(clippy::question_mark)]
-	if transaction.verify().is_err() {
-		return Err(Error::TransactionSignatureVerificationFailure);
-	}
+	transaction
+		.verify()
+		.map_err(|_| Error::TransactionSignatureVerificationFailure)?;
 
-	if let Err(_) = transaction.verify_precompiles(feature_set) {
-		return Err(Error::TransactionPrecompileVerificationFailure);
-	}
+	transaction
+		.verify_precompiles(feature_set)
+		.map_err(|_| Error::TransactionPrecompileVerificationFailure)?;
 
 	Ok(())
 }