Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release/2024-04-16 #550

Merged
merged 29 commits into from
Apr 17, 2024
Merged

release/2024-04-16 #550

merged 29 commits into from
Apr 17, 2024

Conversation

kanej
Copy link
Member

@kanej kanej commented Mar 25, 2024

0.8.0 - 2024-04-16

  • Enable Semantic Highlighting and document symbols behind a feature flag (#523)

💡 The Nomic Foundation is hiring! Check our open positions.


OmarTawfik and others added 22 commits March 25, 2024 20:17
* feat: semantic highlighting

* feat: documentSymbol - project outline

* chore: migrate to slang 0.10.1

semantic highlight

* track performance spans

* error tolerance for document symbols

* decouple onSemanticTokens from solidity-parser

* optimize walking by storing references

* leverage trackTimingSync error handling

* enable documentSymbol and semanticHighlight only on slang-supported platforms

* feature flags

* use finders for walking the cst

* rework semantic highlighting to use cursor finders

* fix linter

* Changes based on PR feedback (part 1)

* Support unnamed function definition on documentSymbols

* refactor based on feedback

* moving version selection to slangHelpers

* add comment to semantic tokens test
As per its deprecation message: "This is a stub types definition.
yaml provides its own type definitions, so you do not need this installed."

I can verify that the latest yaml used ship its own type definitions.
This may take some time (especially on a slow connection) and we should
surface to the user that the command is doing something rather than
being stuck, as the `npm install` output is not surfaced to the user.
I know this is basically no-op since the point of the package is
to group the protocol tests but it makes things a bit cleaner.
The ranges for variable statement changed because the CST shape changed,
which affects the ranges in the test snapshots.
This introduced support for EVM built-ins, so this should substantially
increase correct parse coverage.
This aims to retain the existing behaviour. We should improve and
enhance the behaviour but probably using queries instead, otherwise this
will involve a bit of manual node selection and rules that can change
fairly often.
Corrected some spellings.
Copy link

socket-security bot commented Mar 25, 2024

@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.61%. Comparing base (ec480b3) to head (e339da7).

❗ Current head e339da7 differs from pull request most recent head 247d3fa. Consider uploading reports for the commit 247d3fa to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #550      +/-   ##
==========================================
- Coverage   53.23%   52.61%   -0.63%     
==========================================
  Files         188      228      +40     
  Lines        4824     5318     +494     
  Branches      793      835      +42     
==========================================
+ Hits         2568     2798     +230     
- Misses       2019     2282     +263     
- Partials      237      238       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

xiaoxianBoy and others added 5 commits April 16, 2024 10:55
This bumps minimum required GLIBC to 2.28, which we use in Slang.
It seems that it will not try to fuzzy match the items anymore but
rather rely on the user to pick the correct task type/group first,
before showing the relevant options.

This fixes the issue by explicitly specifying the "hardhat" task type.
@kanej kanej changed the title release/2024-03-25 release/2024-04-16 Apr 16, 2024
@kanej kanej force-pushed the release/2024-03-25 branch from 247d3fa to df2387b Compare April 16, 2024 10:11
Copy link

socket-security bot commented Apr 16, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/[email protected], npm/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@kanej
Copy link
Member Author

kanej commented Apr 16, 2024

@SocketSecurity ignore npm/[email protected]

Ignore the post install script sponsorship message.

@kanej
Copy link
Member Author

kanej commented Apr 16, 2024

@SocketSecurity ignore npm/[email protected]

Because of course.

Update the package version and changelog for the `0.8.0 - 2024-04-16`
release.
@kanej kanej force-pushed the release/2024-03-25 branch from df2387b to 8b346e2 Compare April 16, 2024 11:24
@kanej kanej merged commit fe6254a into main Apr 17, 2024
5 checks passed
@kanej kanej deleted the release/2024-03-25 branch April 17, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants