-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release/2024-04-16 #550
release/2024-04-16 #550
Conversation
* feat: semantic highlighting * feat: documentSymbol - project outline * chore: migrate to slang 0.10.1 semantic highlight * track performance spans * error tolerance for document symbols * decouple onSemanticTokens from solidity-parser * optimize walking by storing references * leverage trackTimingSync error handling * enable documentSymbol and semanticHighlight only on slang-supported platforms * feature flags * use finders for walking the cst * rework semantic highlighting to use cursor finders * fix linter * Changes based on PR feedback (part 1) * Support unnamed function definition on documentSymbols * refactor based on feedback * moving version selection to slangHelpers * add comment to semantic tokens test
As per its deprecation message: "This is a stub types definition. yaml provides its own type definitions, so you do not need this installed." I can verify that the latest yaml used ship its own type definitions.
This may take some time (especially on a slow connection) and we should surface to the user that the command is doing something rather than being stuck, as the `npm install` output is not surfaced to the user.
I know this is basically no-op since the point of the package is to group the protocol tests but it makes things a bit cleaner.
The ranges for variable statement changed because the CST shape changed, which affects the ranges in the test snapshots.
This introduced support for EVM built-ins, so this should substantially increase correct parse coverage.
This aims to retain the existing behaviour. We should improve and enhance the behaviour but probably using queries instead, otherwise this will involve a bit of manual node selection and rules that can change fairly often.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #550 +/- ##
==========================================
- Coverage 53.23% 52.61% -0.63%
==========================================
Files 188 228 +40
Lines 4824 5318 +494
Branches 793 835 +42
==========================================
+ Hits 2568 2798 +230
- Misses 2019 2282 +263
- Partials 237 238 +1 ☔ View full report in Codecov by Sentry. |
This bumps minimum required GLIBC to 2.28, which we use in Slang.
It seems that it will not try to fuzzy match the items anymore but rather rely on the user to pick the correct task type/group first, before showing the relevant options. This fixes the issue by explicitly specifying the "hardhat" task type.
247d3fa
to
df2387b
Compare
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
@SocketSecurity ignore npm/[email protected] Ignore the post install script sponsorship message. |
@SocketSecurity ignore npm/[email protected] Because of course. |
Update the package version and changelog for the `0.8.0 - 2024-04-16` release.
df2387b
to
8b346e2
Compare
0.8.0 - 2024-04-16