Run solidity tracing logic in EDR #5769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the `MessageTrace` from the (experimental) public API and only hides it behind our internal API, where it is used for stack trace logic. We want to move this type to Rust to decrease the overhead of the value passing across the FFI and it would allow us to remove/not export this type entirely from Rust when porting the stack trace logic.
🦋 Changeset detectedLatest commit: 86ed8e5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kanej
reviewed
Sep 23, 2024
packages/hardhat-core/test/internal/hardhat-network/stack-traces/test.ts
Show resolved
Hide resolved
kanej
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates EDR to the latest minor version and adapts the code so that solidity tracing is done on the EDR side.
Most of the changes in this PR are about deleting a lot of typescript code and replacing it with re-exports from EDR. Compare for example
return-data.tsin main vs its content in this PR.Almost all the changes under
hardhat-core/src/internal/hardhat-network/are like that.