Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Optimism provider #5840

Closed
wants to merge 4 commits into from
Closed

feat: add Optimism provider #5840

wants to merge 4 commits into from

Conversation

Wodann
Copy link
Member

@Wodann Wodann commented Oct 22, 2024

A draft PR for adding Optimism support in EDR using the @ignored/edr-optimism package, intended for the alpha.

@Wodann Wodann self-assigned this Oct 22, 2024
Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 8:22am

Copy link

changeset-bot bot commented Oct 22, 2024

⚠️ No Changeset found

Latest commit: b318a4b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Oct 22, 2024
@Wodann Wodann changed the title Feat/optimism feat: add Optimsim provider Oct 22, 2024
@Wodann Wodann changed the title feat: add Optimsim provider feat: add Optimism provider Oct 22, 2024
@schaable
Copy link
Member

@Wodann I've merged this PR into the feat/edr-provider branch, so we can close this. There are a couple of enums, like StackTraceEntryType and MineOrdering, that still need to be converted to constants. I've casted the values for now to get things working, but we should revisit this in the future to clean it up.

@Wodann
Copy link
Member Author

Wodann commented Oct 24, 2024

@Wodann I've merged this PR into the feat/edr-provider branch, so we can close this. There are a couple of enums, like StackTraceEntryType and MineOrdering, that still need to be converted to constants. I've casted the values for now to get things working, but we should revisit this in the future to clean it up.

Are enums prohibited?

Could you provide an example of what you'd like to be generated instead of an enum?

@schaable
Copy link
Member

@Wodann I've merged this PR into the feat/edr-provider branch, so we can close this. There are a couple of enums, like StackTraceEntryType and MineOrdering, that still need to be converted to constants. I've casted the values for now to get things working, but we should revisit this in the future to clean it up.

Are enums prohibited?

Could you provide an example of what you'd like to be generated instead of an enum?

The issue is that we have isolatedModules set to true to ensure compatibility with single-file transpilation tools like tsx. With isolatedModules, const enums can’t be inlined, since this setting assumes each file compiles independently rather than together.

Instead of using enums, it would be better to generate constants, similar to what was done for SpecId.

@Wodann
Copy link
Member Author

Wodann commented Oct 25, 2024

The issue is that we have isolatedModules set to true to ensure compatibility with single-file transpilation tools like tsx. With isolatedModules, const enums can’t be inlined, since this setting assumes each file compiles independently rather than together.

Instead of using enums, it would be better to generate constants, similar to what was done for SpecId.

Thanks for explaining! I'll add a task to do that and add you as a reviewer.

@alcuadrado
Copy link
Member

Thanks a ton for this PR, @Wodann :) @schaable incorporated these changes into #5811.

I'm closing this PR to clean up the repo.

@Wodann
Copy link
Member Author

Wodann commented Oct 29, 2024

Issue added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready This issue is ready to be worked on
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants