Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix some typos #1231

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: fix some typos #1231

wants to merge 1 commit into from

Conversation

lencap
Copy link

@lencap lencap commented Jan 27, 2025

fix some typos

@lencap lencap requested review from a team as code owners January 27, 2025 10:17
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 27, 2025

⚠️ No Changeset found

Latest commit: 4131994

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@OmarTawfik OmarTawfik enabled auto-merge February 4, 2025 13:27
@OmarTawfik OmarTawfik disabled auto-merge February 4, 2025 13:32
OmarTawfik
OmarTawfik requested changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@OmarTawfik OmarTawfik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crates/metaslang/graph_builder/src/variables.rs is from a forked external crate, and we should minimize changes to it. The other two files LGTM. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmarTawfik OmarTawfik OmarTawfik requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lencap @OmarTawfik