Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced imp.load_source with importlib.machinery.SourceFileLoader #412

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

mvertens
Copy link
Contributor

@mvertens mvertens commented Oct 15, 2024

the module imp no will longer be supported in python3.12 and later.
Currently we are using python3.11 in noresm to deal with this limitation. But the desire is to move to python 3.12 in the near future.
The suggested recommendation is to replace
imp.load_source with importlib.machinery.SourceFileLoader
Testing: verified that ERR_Ld3.TL319_tn14.NOIIAJRAOC.betzy_intel.blom-hybrid built successfully (when the same change was made in cice)

@mvertens mvertens requested a review from TomasTorsvik October 15, 2024 14:07
@mvertens mvertens added this to the NorESM2.5 - BLOM/iHAMOCC milestone Oct 15, 2024
@TomasTorsvik
Copy link
Contributor

We get errors with the mpi builds in the mod_xc.F90 file. Don't understand why this should break due to changes in cime_config, so maybe it's something in the test setup that goes wrong.

Copy link
Contributor

@TomasTorsvik TomasTorsvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mvertens , looks fine to me.

@TomasTorsvik TomasTorsvik self-assigned this Oct 16, 2024
@TomasTorsvik TomasTorsvik merged commit cbca1a6 into NorESMhub:master Oct 16, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants