Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert setting of use_ARCTIC variable #425

Merged
merged 1 commit into from
Oct 27, 2024
Merged

Revert setting of use_ARCTIC variable #425

merged 1 commit into from
Oct 27, 2024

Conversation

TomasTorsvik
Copy link
Contributor

@TomasTorsvik TomasTorsvik commented Oct 25, 2024 •
edited
Loading

This PR reverts the setting of the use_arctic variable back to being determined by a CPP flag.

The use_arctic variable is applied in the subroutine xcspmd from mod_xc, which is called in blom_initbefore rdlim. Hence, use_arctic is used before the namelist variables are read. It would be nice if we could remove the ARCTIC CPP flag, but it will have to be done in a different way.

Testing:

  • This PR works for the stand-alone single_column test run.
  • PASS for test SMS_D_Ld1.T62_tn14.NOINYOC.betzy_intel based on noresm2_5_alpha07

@TomasTorsvik TomasTorsvik self-assigned this Oct 25, 2024
@TomasTorsvik TomasTorsvik added the bug Something isn't working label Oct 25, 2024
@TomasTorsvik TomasTorsvik linked an issue Oct 25, 2024 that may be closed by this pull request
1D test setup broken after PR #410 #416
Closed
mvertens
mvertens approved these changes Oct 26, 2024
View reviewed changes
Copy link
Contributor

@mvertens mvertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomasTorsvik - thanks for reverting this.

@TomasTorsvik TomasTorsvik merged commit d9c8445 into NorESMhub:master Oct 27, 2024
5 checks passed
@TomasTorsvik TomasTorsvik deleted the bugfix_1D_crash branch October 27, 2024 15:12
@TomasTorsvik TomasTorsvik mentioned this pull request Oct 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvertens mvertens mvertens approved these changes

@matsbn matsbn Awaiting requested review from matsbn

@milicak milicak Awaiting requested review from milicak

@JorgSchwinger JorgSchwinger Awaiting requested review from JorgSchwinger

@jmaerz jmaerz Awaiting requested review from jmaerz

Assignees

@TomasTorsvik TomasTorsvik

Labels
bug Something isn't working
Projects
NorESM Development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1D test setup broken after PR #410
2 participants
@TomasTorsvik @mvertens