Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error message if user_nl_blom includes hash comments #450

Merged

Conversation

TomasTorsvik
Copy link
Contributor

Same as #448, applied for the release-1.6 branch.

@TomasTorsvik TomasTorsvik added the documentation Improvements or additions to documentation label Dec 12, 2024
@TomasTorsvik TomasTorsvik self-assigned this Dec 12, 2024
Copy link
Collaborator

@jmaerz jmaerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me - thanks for taking care!

@jmaerz
Copy link
Collaborator

jmaerz commented Dec 12, 2024

Any ideas, why the continuous integration testing fails? - I had similar issues in #449

@jmaerz
Copy link
Collaborator

jmaerz commented Dec 12, 2024

As written in #451 one could handle the line also as user comment line - again, not knowing ad hoc, whether this introduces other side effects...

@TomasTorsvik
Copy link
Contributor Author

Any ideas, why the continuous integration testing fails? - I had similar issues in #449

@jmaerz - no, not really. Looks like something connected with linking to the MPI library. I see a lot of messages "undefined reference to `mpi_' from building mod_xc.F.

@jmaerz
Copy link
Collaborator

jmaerz commented Dec 12, 2024

@TomasTorsvik , yes, I saw it, similar in #449 - but there just with the undefined references to mpi functions...

@TomasTorsvik TomasTorsvik merged commit cec07be into NorESMhub:release-1.6 Dec 13, 2024
2 of 4 checks passed
@TomasTorsvik TomasTorsvik deleted the r1.6-feature_user_nl_file branch December 13, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants