Add N2 compset for NOINYOC that still uses isopycnic coordinates #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stupid question, wouldn't it be better to keep the old naming for the |
|
Going ahead, these "old" compsets will be removed at some point. Also, there are already a couple of other (ocean-only) compsets that use this naming convention. |
|
Will these compsets and changes be somewhere documented? |
|
Once we want to scientifically support these compsets, they should be documented. Not sure if this will be the case for release 2.3? For now they only work with --run-unsopported |
TomasTorsvik
approved these changes
Dec 16, 2024
jmaerz
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NOINYOC compset is used a lot for testing, so we need a N2NOINYOC compset that still selects isopucnic coordinates as a default.