Increase value of sediment POC degradation constant #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @JorgSchwinger , just to be sure (and to document): the new value is for the default model (so not for the recently included T- and O2-dependent sediment remin #454), right? |
jmaerz
approved these changes
Jan 16, 2025
|
It is ok-ish for both, the T-dependent remineralization does not have such a huge impact (globally) as far as I have seen. As mentioned above, this is not yet fine-tuned, but the order of magnitude is now much better. |
|
Hi @JorgSchwinger , thanks for checking - yes, the value is generally closer to what I would expect (and to which I tuned the sediment thus far for the N-cycle). |
17 tasks
TomasTorsvik
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This increases the default value of disso_poc quite substantially. A larger value for this constant leads to a number of improvements (higher PP, reduced deep sea oxygen biases). Even if this parameter will need fine-tuning, the new value has a much better order of magnitude.
closes #461