-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Megan fates #10
Megan fates #10
Conversation
@rosiealice - I'd like to merge this at this point even though the check boxes have not been done. We need this for noresm2_5_alpha08 unless I point to my own fork for CTSM. Are you okay with merging this now? |
Sounds great. Did you manage to run the tests or do you want to just merge it anyway? I don't think it requires a change to the documentation yet as we do not have seperate NorESM-FATES documentation and this would thus perhaps need to be done when merging back into the main FATES repo. |
@rosiealice - I ran the new test suite I introduced. Out of 24 tests - 19 passed. The following 5 failed. The create_newcase are known failures since this requires numpy to be available on betzy as a module - and that is currently not working. I fixed the XML test - but have not rerun. This leaves 2 failed tests that I have not had a chance to look at yet.
In addition, I did run this code along with the updated ctsm PR in a debug tests for n1850 with fates-sp and it passed! |
Description:
New Megan PR to update FATES to create megan PFTs. coordinated with CTSM side PR at
NorESMhub/CTSM#74
Collaborators:
Expectation of Answer Changes:
Checklist:
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: