Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stop delay and threading error #73

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Chapoly1305
Copy link
Contributor

For Issue #58
Tested on Macbook and Ubuntu 22.04, the script is now responsive when press stop button without giving a pop-up error.

The previous pull request (#64) was not merged but the head brach was deleted by accident. Creating a new pull request with identical modification.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Chapoly1305 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@e-rk
Copy link
Collaborator

e-rk commented Nov 14, 2024

I have gave the change a try and it looks like there is a problem with stopping the capture on Linux. When the Stop capturing packets button is clicked, the extcap does not close the serial port and the process does not terminate.
Unfortunately the code around the cleanup is very flaky and difficult to get right on every operating system.

@Chapoly1305
Copy link
Contributor Author

Chapoly1305 commented Nov 14, 2024

@e-rk Hi, thanks for the test. From your description, it sounds you have tested on the wrong file? Your description matches exactly the old script, and that's why I modified the previous script. I have personally tested on Linux and other users reported positive feedback on #58, So I kindly ask your favor to try again, ensure you replaced the old file and are using the modified script. If you may, remove the existing files from local and global, then add this new python file. Thanks.

image

@e-rk
Copy link
Collaborator

e-rk commented Nov 15, 2024

I have re-tested again on Wireshark v3.2.3 on Ubuntu 20.04 and yes, that's the problem I'm seeing with this change unfortunately. Maybe it's due to the difference in Wireshark version. I tried to test with the v4.4.1-1 on Archlinux, but that version seems to fail for some different reason during initialization. I'll try to investigate this on my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants