Leak corrections and testing #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjosv
force-pushed
the
leak-corrections
branch
from
16b70df
to
aee55ff
Compare
zuiderkwast
reviewed
Nov 30, 2020
zuiderkwast
reviewed
Nov 30, 2020
zuiderkwast
reviewed
Nov 30, 2020
bjosv
force-pushed
the
leak-corrections
branch
3 times, most recently
from
ee3c376
to
9f94c34
Compare
zuiderkwast
reviewed
Nov 30, 2020
zuiderkwast
reviewed
Nov 30, 2020
zuiderkwast
reviewed
Nov 30, 2020
zuiderkwast
approved these changes
Nov 30, 2020
The option is set when generating makefiles, like the other configs: `cmake -DDOWNLOAD_HIREDIS=ON -DUSE_SANITIZER=leak ..` * Build and test using sanitizers in CI as a new job * Leak found so sanitizers `leak` and `address` temporary disabled in CI
Leaks in multi-command handling: - redisClusterGetReply() - command_post_fragment()
bjosv
force-pushed
the
leak-corrections
branch
from
9f94c34
to
866e67c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correcting 2 iterator leaks, now covered with tests.
Leaks in multi-command handling:
As also found in: fix a bug which cause mem leak when post multikey result vipshop/hiredis-vip#57
Add option to build using sanitizers
cmake -DDOWNLOAD_HIREDIS=ON -DUSE_SANITIZER=leak ..Build and test using sanitizers in CI aswell