Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of password authentication (AUTH) #3

Merged
merged 1 commit into from
Nov 13, 2020
Merged

Conversation

bjosv
Copy link
Collaborator

@bjosv bjosv commented Nov 13, 2020

When a password is configured it will be sent right
after a connection to a Redis instance is setup,
via the AUTH command.

Added API:
redisClusterSetOptionPassword(cc, "password");

@bjosv bjosv requested a review from zuiderkwast November 13, 2020 09:56
Copy link
Collaborator

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only some minor comments/questions.

When a password is configured it will be sent right
after a connection to a Redis instance is setup,
via the AUTH command.

Added API:
    redisClusterSetOptionPassword(cc, "password");
@bjosv bjosv merged commit 53f9667 into master Nov 13, 2020
@bjosv bjosv deleted the auth_support branch November 16, 2020 10:08
@bjosv
Copy link
Collaborator Author

bjosv commented Nov 29, 2020

Mostly identical to vipshop/hiredis-vip#22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants