Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move wow from dev-tools #96

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Conversation

mboukhalfa
Copy link
Contributor

@mboukhalfa mboukhalfa commented Jan 31, 2024

Refactoring dev-tools: This PR is moving part of wow folder from dev-tools to here

@mboukhalfa mboukhalfa force-pushed the move-docs-from-dev-tools-repo branch from 9343b82 to 5d020ef Compare January 31, 2024 17:29
@tuminoid
Copy link
Member

tuminoid commented Feb 1, 2024

While moving them, we need to check if all of it is valid still. We also need to see if some of it would actually belong somewhere in the metal3-io side. For example, CI stuff is to be handled by the metal3-io CI team, not only ESJ.
/hold

@mboukhalfa
Copy link
Contributor Author

While moving them, we need to check if all of it is valid still. We also need to see if some of it would actually belong somewhere in the metal3-io side. For example, CI stuff is to be handled by the metal3-io CI team, not only ESJ. /hold

I am thinking anything needs access to cleura or one of the services that are private to ESJ cannot be on metal3-io the CI docs has a part involving accessing to cleura vms and managing them although the first part checking jenkins and logs can be moved to metal3-io but we end up splitting the file I guess

wow/github-workflow.md Show resolved Hide resolved
wow/github-workflow.md Outdated Show resolved Hide resolved
wow/github-workflow.md Outdated Show resolved Hide resolved
wow/jenkins_ci/README.md Outdated Show resolved Hide resolved
@mboukhalfa mboukhalfa force-pushed the move-docs-from-dev-tools-repo branch 3 times, most recently from b2e8c4a to 0261a09 Compare February 1, 2024 17:12
@mboukhalfa mboukhalfa force-pushed the move-docs-from-dev-tools-repo branch from 0261a09 to 47f849b Compare February 1, 2024 17:15
@mboukhalfa mboukhalfa requested a review from lentzi90 February 15, 2024 17:07
@mboukhalfa
Copy link
Contributor Author

While moving them, we need to check if all of it is valid still. We also need to see if some of it would actually belong somewhere in the metal3-io side. For example, CI stuff is to be handled by the metal3-io CI team, not only ESJ. /hold

I am thinking anything needs access to cleura or one of the services that are private to ESJ cannot be on metal3-io the CI docs has a part involving accessing to cleura vms and managing them although the first part checking jenkins and logs can be moved to metal3-io but we end up splitting the file I guess

@tuminoid can be unlocked ? or you want this to be split ?

@tuminoid
Copy link
Member

We need to do the split sooner or later. The minimum requirement for this PR is that we don't move outdated information. As this is not an old study being moved for archiving, but ways of working, it should be verified that it still applies, and updated or removed if it isn't needed anymore.

@mboukhalfa
Copy link
Contributor Author

We need to do the split sooner or later. The minimum requirement for this PR is that we don't move outdated information. As this is not an old study being moved for archiving, but ways of working, it should be verified that it still applies, and updated or removed if it isn't needed anymore.

This should now meet the minimum requisites we can create a ticket if something need to be moved to the official docs on metal3

@tuminoid
Copy link
Member

/approve
/unhold

Sure.

Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot
Copy link
Member

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90, tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot merged commit f8520fb into main Apr 4, 2024
5 checks passed
@metal3-io-bot metal3-io-bot deleted the move-docs-from-dev-tools-repo branch April 4, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants