-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move wow from dev-tools #96
Conversation
9343b82
to
5d020ef
Compare
While moving them, we need to check if all of it is valid still. We also need to see if some of it would actually belong somewhere in the metal3-io side. For example, CI stuff is to be handled by the metal3-io CI team, not only ESJ. |
I am thinking anything needs access to cleura or one of the services that are private to ESJ cannot be on metal3-io the CI docs has a part involving accessing to cleura vms and managing them although the first part checking jenkins and logs can be moved to metal3-io but we end up splitting the file I guess |
b2e8c4a
to
0261a09
Compare
0261a09
to
47f849b
Compare
@tuminoid can be unlocked ? or you want this to be split ? |
We need to do the split sooner or later. The minimum requirement for this PR is that we don't move outdated information. As this is not an old study being moved for archiving, but ways of working, it should be verified that it still applies, and updated or removed if it isn't needed anymore. |
This should now meet the minimum requisites we can create a ticket if something need to be moved to the official docs on metal3 |
/approve Sure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90, tuminoid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Refactoring dev-tools: This PR is moving part of wow folder from dev-tools to here