-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure explain() for iterative estimation with convergence detection, verbose arguments ++ #396
Conversation
Just some notes for myself on where to catch up after the holiday:
Depending on how things go as I get back on this in august, @LHBO might take a look at the code structure some time after point 3 is done. |
This reverts commit d140325.
Hi @aredelmeier @LHBO @jonlachmann This is closing in on a merge. Just a few things misisng now, I think. I hope to be able to merge this some time this weekend. Here is what remains:
@jonlachmann You may want to merge this into your forecast fixing branch. @LHBO If you want to , I actually think you can safely start on the asymmetric stuff from the current stage. What remains will not change much of the code. |
…tion, verbose arguments ++ (NorskRegnesentral#396) Dealing with the leftovers in separate PRS into NorskRegnesentral#402.
Very early draft. Lots of cleanup and moving things around remains, but the general overall structure will probably be close to what we got here.
To be done in this PR (some may be removed here and handled in separate PRs):
verbose
with arguments - Add verbose = c("basic","shapley","vS_details"), with "basic" as the default, showing what is currently going on in the function, the filename of the tempfile, and what iteration we are at (+ later estimate of the remaining computationt time) NULL or "" should give no printout at all, "shapley" means printing intermediate shapley estimates, "vs_details" means printing results while estimating the vS_functions (where this is done in more than a single step).Note: All non-exact methods fails now (also the Shapley values estimates) since shapley_setup is now called after setup_approach. All tests for Shapley values pass if these calls are but back to the original order (but we don't want that in the future).