Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shapr 1.0.0 #401

Closed
wants to merge 175 commits into from
Closed

Shapr 1.0.0 #401

wants to merge 175 commits into from

Conversation

martinju
Copy link
Member

@martinju martinju commented Oct 5, 2024

This should merge to master what eventually becomes shapr 1.0.0.
All changes up until that point should be made through separate PRs to be merge into the shapr_1.0.0 branch

Required in this PR

  • Add adaptive estimation
  • Add verbose
  • Get shaprpy to work again
  • Get explain_forecast to work again
  • Update explain_forecast to the new adaptive version
  • Add asymmetric/causal to explain

Other mandatory TODOs

  • Update the NEWS file

Minor TODOs (some might be skipped before release)

  • Consider moving compute_sd, n_boot_samps, max_batch_size, min_n_batches, saving_path out of adaptive_arguments and into a new argument list called something like additional_estimation_args
  • Consider renaming adaptive_arguments to adaptive_args
  • Consider moving keep_samp_for_vS and MSEv_uniform_comb_weights into a input arg called something like output_args
  • Consider renaming shapley_reweighting to kernelSHAP_reweighting
  • A bit more cleaning on all vignettes (all are currently without code errors, and at an OK level, I think)
  • A bit more cleaning on the documentation (also OK at this stage I think, but new eyes don't hurt)
  • Delete unnecessary scripts and devel code and other leftover from inst
  • Consider adding parallelization to the boostrapping
  • Consider moving saving_path and iter_res_dt to the main output to make it easier to access for users

@martinju
Copy link
Member Author

martinju commented Oct 6, 2024

Moving this to #402 instead

@martinju martinju closed this Oct 6, 2024
@martinju martinju deleted the shapr_1.0.0 branch October 6, 2024 13:31
@LHBO LHBO mentioned this pull request Oct 8, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants