Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip vaeac tests on mac os #403

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Skip vaeac tests on mac os #403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d5a5be8
skip vaeac tests on mac os
martinju Oct 7, 2024
16253fc
GHA running also for PRs into shapr-1.0.0
martinju Oct 7, 2024
e37a39d
forgot one test
martinju Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/R-CMD-check.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@

on:
push:
branches: [main, master, cranversion, devel]
branches: [main, master, cranversion, devel, 'shapr-1.0.0']
pull_request:
branches: [main, master, cranversion, devel]
branches: [main, master, cranversion, devel, 'shapr-1.0.0']

name: R-CMD-check

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lint-changed-files.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
# Need help debugging build failures? Start at https://github.com/r-lib/actions#where-to-find-help
on:
pull_request:
branches: [main, master]
branches: [main, master, cranversion, devel, 'shapr-1.0.0']

name: lint-changed-files

Expand Down
3 changes: 3 additions & 0 deletions tests/testthat/test-regular-output.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ test_that("output_lm_numeric_ctree", {
})

test_that("output_lm_numeric_vaeac", {
skip_on_os("mac") # The code runs on macOS, but it gives different Shapley values due to inconsistencies in torch seed
expect_snapshot_rds(
explain(
testing = TRUE,
Expand Down Expand Up @@ -198,6 +199,7 @@ test_that("output_lm_categorical_ctree", {
})

test_that("output_lm_categorical_vaeac", {
skip_on_os("mac") # The code runs on macOS, but it gives different Shapley values due to inconsistencies in torch seed
expect_snapshot_rds(
explain(
testing = TRUE,
Expand Down Expand Up @@ -344,6 +346,7 @@ test_that("output_lm_mixed_ctree", {
})

test_that("output_lm_mixed_vaeac", {
skip_on_os("mac") # The code runs on macOS, but it gives different Shapley values due to inconsistencies in torch seed
expect_snapshot_rds(
explain(
testing = TRUE,
Expand Down
Loading