Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swagger specification for AI feedback component #20

Merged
merged 2 commits into from
Jan 23, 2022
Merged

Conversation

alasali1
Copy link
Contributor

Rough swagger specification defining feedback resource, and paths for HTTP requests.
Closes #5

@alasali1 alasali1 requested review from toddysm and dansjack January 18, 2022 08:11
@alasali1 alasali1 changed the base branch from main to backend January 20, 2022 01:10
Copy link
Contributor

@dale108 dale108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will have to change once Cyrus and other finish their work (for instance, I think that we will want to keep track of tags) but for an initial pass, this looks good.

@alasali1 alasali1 merged commit ea6495f into backend Jan 23, 2022
@alasali1
Copy link
Contributor Author

This will have to change once Cyrus and other finish their work (for instance, I think that we will want to keep track of tags) but for an initial pass, this looks good.

Got it. Thank you for feedback.

@alasali1
Copy link
Contributor Author

alasali1 commented Jan 23, 2022

User Story:

Create a Swagger specification for AI feedback component, feedback resource
Estimating Time:

2 hours
Acceptance Criteria:

Create a YAML document with POST and GET requests
Return 200 for GET and 201 for POST on Postman

Copy link
Contributor

@CourtneyHoppus CourtneyHoppus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the host and the basepath are correct, this looks like something from the swagger editor.
I do not understand the purpose of the get request.
My understanding is that we are only posting feedback to the assignment. The response to that request will be the coaching on that feedback or an error.
I am also a little confused on the seen property being required.

@alasali1
Copy link
Contributor Author

I don't think the host and the basepath are correct, this looks like something from the swagger editor. I do not understand the purpose of the get request. My understanding is that we are only posting feedback to the assignment. The response to that request will be the coaching on that feedback or an error. I am also a little confused on the seen property being required.

Thank you for the feedback. I am going to fix the seen property and ID being required, because the ID should be generated by POST, and the seen property does not need to be required. The get request is more like a rough draft test to see that the feedback endpoint is working properly it will be removed and I will add more endpoints as the project moves along. I was not sure which host/basepath to point the API. So for testing purposes I kept the one generated from the swagger editor.

KristinJJ pushed a commit that referenced this pull request Feb 18, 2022
Swagger specification for AI feedback component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create the Swagger specification for the application
3 participants