-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Research: Deploy React to S3 GitHub Action Instruction #27
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good and very detail, if can add some Known troubleshooting steps to the documentation will better!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation is easy to follow and nicely detailed. I think you just need an initial estimate to complete task. Good job!
Thank you guys!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR pushes more than the document that was created to fulfill the connected issue.
I believe it was based off a branch that has not been merged yet, and contains those files as well.
Their is also a .vscode
file being pushed, I believe those are your personal editor settings, so they should not be included.
Deleted the requested .vscode/settings.json from the PR
Deleted the requested .vscode settings.json file that should not be part of the push. Requested change complete. Will merge this branch to once the frontend PR #16 is merged to development first. |
Documentation:
Closes #8
(User Story, Total time to complete the Sprint, and Acceptance Criteria can be found on the connected Issue)
File Location
The
reactS3Action.md
file can be found in thefrontend/documentation
folder for reference.Time Spent on Issue:
Gallery & GitHub Action specific Instruction:
On the GitHub Repo:
Create key/value pairs for the following sensitive information:
Be sure to note the names of the keys:
How the secrets will show once submitted:
Setup GitHub Actions
What this file obtains:
The file is made of 3 different parts to help with the understanding:
To save, click on the Start Commit then Commit New File.
Doing so will:
This should successfully complete the setup.
Troubleshooting:
(See documentation file for more details)