Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swagger generated project with node modules. Removed the GET request … #37

Open
wants to merge 1 commit into
base: backend
Choose a base branch
from
Open

Swagger generated project with node modules. Removed the GET request … #37

wants to merge 1 commit into from

Conversation

alasali1
Copy link
Contributor

@alasali1 alasali1 commented Jan 31, 2022 •
edited
Loading

Description

New changes for solution to #5

This PR adds removes the unnecessary GET request from the Swagger API, the YAML file is generated as a swagger project with its own folder and dependencies, to make testing on swagger editor and UI possible.

Gallery

An example of the swagger editor running.
2022-02-01

Testing

Pre-reqs

  • You need visual studio code installed with the command line.
  • Within the directory of the swagger.yaml file located in \backend\AIFeedbackCoachSpec\api\swagger type "swagger project edit" within the command line of visual studio code

Steps

  • On the UI side of the editor click try this operation under POST/feedback.
  • must type a message in the message text box for the POST request
  • Click send request

Troubleshooting

I get a vague error on the swagger project editor stating "Bad request". I am still looking for a fix to this issue.

@alasali1
Swagger generated project with node modules. Removed the GET request …
c5434fe 
…and changed server to a mock server from postman
@KristinJJ KristinJJ added this to the Sprint 02 milestone Feb 17, 2022
@KristinJJ KristinJJ linked an issue Feb 17, 2022 that may be closed by this pull request
Create the Swagger specification for the application #5
Closed
2 tasks
KristinJJ
KristinJJ reviewed Feb 25, 2022
View reviewed changes
Copy link
Contributor

@KristinJJ KristinJJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alasali1 , could you add some more test steps? I'm not really sure what I am supposed to be seeing. This is what I get after I click the "Send Request" button:

Screen Shot 2022-02-24 at 11 47 42 PM

@KristinJJ
Copy link
Contributor

Also just a reminder about this part of the Syllabus under Task Management for full credit:

·      Task must be created and appear on the project board
·      Task must be tagged with the proper labels (team and bug/task)
·      Task must be tagged with the proper milestone
·      Task must be assigned to the responsible developer
·      Task must be in In Progress state while in development
·      Task must be in Done state at the end of the sprint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KristinJJ KristinJJ KristinJJ left review comments

Assignees

@alasali1 alasali1

Labels
Backend Team
Projects
None yet
Milestone
Sprint 02
Development

Successfully merging this pull request may close these issues.

Create the Swagger specification for the application
2 participants
@alasali1 @KristinJJ