-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React S3 Action deploy #59
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done! I appreciate the thorough documentation.
The action worked as expected and I checked that the site was available at the bucket url.
- uses: actions/checkout@v1 | ||
- run: npm install | ||
working-directory: ./frontend/floop_feedback | ||
- run: npm install mini-css-extract-plugin@~2.4.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is exactly what I had to install when I mentioned I was having trouble building the app last night!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done! Very easy to follow instructions.
commit 875b6bc Author: Daniel <[email protected]> Date: Thu Feb 3 16:02:49 2022 -0800 Python script run feedback datasets#22 (#30) * first * update on assignment * Modified task.py * deleted floop_data_15k.json and word2vec11.model * removed the commented * word2vec11.model file added * updated * update line 83 * update csv file * updates of * Update on the code * floop_data_15k.json deleted * DataFromS3 to Field1 changed * line 25 added * Update on task.py and added info.md file commit 4880bf7 Merge: d0940f8 8c0b991 Author: ChrisNavo <[email protected]> Date: Thu Feb 3 14:11:15 2022 -0800 Merge pull request #59 from North-Seattle-College/react-S3-action React S3 Action deploy commit 8c0b991 Author: CNavo <[email protected]> Date: Wed Feb 2 21:50:37 2022 -0800 React S3 Action deploy
* feat(makeReactBucket.sh): bypass user input with shell arg * feat(makeReactBucket.sh): make script callable from anywhere * chore(makeReactBucket.sh): make quotes convention more consistent * feat(makeReactBucket.sh): extract initials validation function * refactor(/devops): moved function to a helper file * refactor(/devops): make function take arg instead of use global * chore(/devops): lint, change from .sh to .bash * refactor(makeReactBucket.json): converted to yml for consistency with other template files * chore(makeReactBucket.json): delete file * Merge development into dj-40 commit 875b6bc Author: Daniel <[email protected]> Date: Thu Feb 3 16:02:49 2022 -0800 Python script run feedback datasets#22 (#30) * first * update on assignment * Modified task.py * deleted floop_data_15k.json and word2vec11.model * removed the commented * word2vec11.model file added * updated * update line 83 * update csv file * updates of * Update on the code * floop_data_15k.json deleted * DataFromS3 to Field1 changed * line 25 added * Update on task.py and added info.md file commit 4880bf7 Merge: d0940f8 8c0b991 Author: ChrisNavo <[email protected]> Date: Thu Feb 3 14:11:15 2022 -0800 Merge pull request #59 from North-Seattle-College/react-S3-action React S3 Action deploy commit 8c0b991 Author: CNavo <[email protected]> Date: Wed Feb 2 21:50:37 2022 -0800 React S3 Action deploy
* feat(makeReactBucket.sh): bypass user input with shell arg * feat(makeReactBucket.sh): make script callable from anywhere * chore(makeReactBucket.sh): make quotes convention more consistent * feat(makeReactBucket.sh): extract initials validation function * refactor(/devops): moved function to a helper file * refactor(/devops): make function take arg instead of use global * chore(/devops): lint, change from .sh to .bash * refactor(makeReactBucket.json): converted to yml for consistency with other template files * chore(makeReactBucket.json): delete file * Merge development into dj-40 commit 29f3ca6 Author: Daniel <[email protected]> Date: Thu Feb 3 16:02:49 2022 -0800 Python script run feedback datasets#22 (#30) * first * update on assignment * Modified task.py * deleted floop_data_15k.json and word2vec11.model * removed the commented * word2vec11.model file added * updated * update line 83 * update csv file * updates of * Update on the code * floop_data_15k.json deleted * DataFromS3 to Field1 changed * line 25 added * Update on task.py and added info.md file commit f293101 Merge: 4a8da9b 6f07a1e Author: ChrisNavo <[email protected]> Date: Thu Feb 3 14:11:15 2022 -0800 Merge pull request #59 from North-Seattle-College/react-S3-action React S3 Action deploy commit 6f07a1e Author: CNavo <[email protected]> Date: Wed Feb 2 21:50:37 2022 -0800 React S3 Action deploy
Documentation:
Closes #8
Closes #52
Completes PR #34 from Sprint 1 before Friday 2/4/2022
This PR may include Sprint 2
UPDATE: This PR now includes a
github/workflows
folder system with a working.yml
file that when pushed to development will run abuild
of the React App in a S3 bucket and run the App via AWS' static Website hosting.This PR updated the documentation based on research and testing on how to deploy React to an S3 bucket utilizing GitHub Actions
This includes a frontend documentation folder to store these instructions as well as future issues on the frontend side that require a document/reference.
The .md file instructions include:
(User Story, Total time to complete the Sprint, and Acceptance Criteria can be found on the connected Issue)
File Locations
The
S3-deploy.yml
file can be found in the.github/workfolder
folder for referenceThe
reactS3Action.md
file can be found in thefrontend/documentation
folder for reference.Time Spent on Issue #8:
Time Spent on Issue #52 :
Gallery & GitHub Action specific Instruction:
On the GitHub Repo:
Create key/value pairs for the following sensitive information:
Be sure to note the names of the keys:
How the secrets will show once submitted:
Setup GitHub Actions
Return to your working Branch
.github
folder.github
folder create another folder namedworkflows
workflows
create a.yml
file with a name that describes the action (exampleS3-deploy.yml
).yml
provided by GitHub.yml
file:What this file obtains:
The file is made of 3 different parts to help with the understanding:
To save, click on the Start Commit then Commit New File.
Doing so will:
This should successfully complete the setup.
Running the Build
Test the AWS Website
Properties
tab scroll to the bottom to Static Website Hosting to find the bucket website endpoint.Troubleshooting:
(See documentation file for more details)