-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust rewrite: services and basic routing #165
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't worked with Rust a ton, so take what I say with a grain of salt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great
.unwrap() | ||
.fixed_offset(), | ||
prisma::run::id::equals(run_id), | ||
vec![prisma::data::values::set( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very interesting syntax
DATA_TYPE_NAME.to_owned(), | ||
) | ||
.await | ||
.expect_err("Should error, as no node exists"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should be expecting the proper error that its gonna have
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately the prisma client rust query errors are not typed. It basically is just a wrapper for the error the database returned as a string. Kinda sucks I know.
Rewrite in rust:
Stack
This PR:
Future PR 1:
Future PR 2: