Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(webapp/deps): migrate to Angular v18 #185

Merged
merged 6 commits into from
Sep 17, 2024

Conversation

Char2sGu
Copy link
Contributor

No description provided.

angular-client/src/index.html Show resolved Hide resolved
angular-client/src/app/app.module.ts Outdated Show resolved Hide resolved
angular-client/src/app/app.module.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@RChandler234 RChandler234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fucked with the sidebar design a bit somehow. I honestly like the new one better, but could you make it so the item highlight doesn't overflow on the right side
New:
image
Old:
image

@Char2sGu
Copy link
Contributor Author

Sure. Since we bumped the version of Angular Material and PrimeNG, some updates in these packages might result in unexpected behaviors. I’ll look into that today.

@Char2sGu
Copy link
Contributor Author

image

Copy link
Contributor

@RChandler234 RChandler234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@RChandler234 RChandler234 merged commit 20a408f into develop Sep 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants