Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#156 fault page #211

Draft
wants to merge 23 commits into
base: develop
Choose a base branch
from
Draft

#156 fault page #211

wants to merge 23 commits into from

Conversation

RChandler234
Copy link
Contributor

Changes

This PR is very much in progress rn

Have a running log of the faults. The middle display is going to show important info about a selected fault (will default to the most recent fault). The panel on the right is going to be every data point that corresponds to the point in time the fault was recorded.

Goal is to be able to retrieve/ visualize about 30 seconds of data before the Fault.

To Do

  • Add more mock data to rust server/ hook up clickable faults on the fault list to test querying for data at the datetime of the fault
  • Add any faults to the log component that aren't currently on there (investigate a more programmatic way to do this?)
  • Flesh out UI for data displayed in middle panel
  • Fix up data display on the right (want it to be searchable, using sidebar as a placeholder rn)

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No package-lock.json changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #156 (issue #)

@RChandler234 RChandler234 self-assigned this Sep 22, 2024
@RChandler234
Copy link
Contributor Author

RChandler234 commented Sep 24, 2024

Sends date correctly to backend now; need to search for data not at the exact time (getting only like 0-2 data points rn) and add a new type, transformer to get dataTypeName with the query

@@ -2,10 +2,10 @@ import { Fault } from '../indiv-fault/fault.model';
import { FaultType, FaultTypeModel } from './fault-type.model';

export class BMSFaultType implements FaultTypeModel {
subscribeToFaults(): Fault<FaultTypeModel> {
subscribeToFaults(): Fault<BMSFaultType> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to figure out if we want to implement our own subscribe stuff, or just use Subject<>

@bracyw bracyw self-assigned this Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fault Page
2 participants