-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#156 fault page #211
Draft
RChandler234
wants to merge
23
commits into
develop
Choose a base branch
from
#156-fault-page
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
#156 fault page #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sends date correctly to backend now; need to search for data not at the exact time (getting only like 0-2 data points rn) and add a new type, transformer to get dataTypeName with the query |
bracyw
reviewed
Oct 8, 2024
angular-client/src/pages/fault-page/shared/fault-type/bms-fault-type.model.ts
Outdated
Show resolved
Hide resolved
bracyw
reviewed
Oct 8, 2024
@@ -2,10 +2,10 @@ import { Fault } from '../indiv-fault/fault.model'; | |||
import { FaultType, FaultTypeModel } from './fault-type.model'; | |||
|
|||
export class BMSFaultType implements FaultTypeModel { | |||
subscribeToFaults(): Fault<FaultTypeModel> { | |||
subscribeToFaults(): Fault<BMSFaultType> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to figure out if we want to implement our own subscribe stuff, or just use Subject<>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR is very much in progress rn
Have a running log of the faults. The middle display is going to show important info about a selected fault (will default to the most recent fault). The panel on the right is going to be every data point that corresponds to the point in time the fault was recorded.
Goal is to be able to retrieve/ visualize about 30 seconds of data before the Fault.
To Do
Checklist
It can be helpful to check the
Checks
andFiles changed
tabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
package-lock.json
changes (unless dependencies have changed)Closes #156 (issue #)