Migrate ServerData Protobuf to v2, switch internal struct to chrono + f32, update time sourcing logic #216
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
See title. Was just going to just migrate serverdata and update time sourcing logic, but ran into a ton of bugs with
ClientData
using millisecond timestamps that would require refactoring every instantiation of the struct. So I said fug it and switched the struct to store aDateTime
so any caller can pass in precise time. ThisDateTime
is also how the prisma layer understands time. All times utc!!Also switched the internal data representation to f32 from string because it was really annoying me all of the mapping and parsing back and forth we do. This can be reverted no biggie.
Test Cases
Checklist
It can be helpful to check the
Checks
andFiles changed
tabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
package-lock.json
changes (unless dependencies have changed)