Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#200 switch new run to static atomic #222

Merged
merged 5 commits into from
Oct 25, 2024

Conversation

bracyw
Copy link
Contributor

@bracyw bracyw commented Oct 7, 2024

Changes

Implemented a global AtomicI32 to keep track of current run number.

Notes

Had to do a global Atomic because Atomics couldn't be passed through a post (doesn't have clone trait).

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No package-lock.json changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #200

jr1221
jr1221 previously approved these changes Oct 7, 2024
Copy link
Contributor

@jr1221 jr1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please just test changing run in client still works. You can do this by pointing client to scylla, and then incrementing the run in the client and see if it works.

scylla-server/src/processors/mqtt_processor.rs Outdated Show resolved Hide resolved
@RChandler234
Copy link
Contributor

pls verify that getCurrentRun/ add new run button works correctly in this PR. Right now it's not working on my local (I think bc of an empty db) and causes the UI to say it's disconnected from the backend

jr1221
jr1221 previously approved these changes Oct 25, 2024
Copy link
Contributor

@jr1221 jr1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one thing

@bracyw bracyw requested a review from jr1221 October 25, 2024 23:05
Copy link
Contributor

@jr1221 jr1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bracyw bracyw merged commit 71d79e1 into develop Oct 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Scylla] - Switch new run to static Atomic
3 participants