Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faults no longer spam + no dashes in client id types #246

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

bracyw
Copy link
Contributor

@bracyw bracyw commented Nov 22, 2024

Changes

Fixed fault logic (basically don't let faults spam).

Got rid of dashes in client, and fixed mqtt decode (was sending the full mqtt message topic, instead of take out the node, which may change in the future but for now will work)

Screenshots

Screenshot 2024-11-21 at 7 37 14 PM

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No package-lock.json changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #245

@bracyw bracyw self-assigned this Nov 22, 2024
@bracyw bracyw requested a review from jr1221 November 22, 2024 01:10
Copy link
Contributor

@jr1221 jr1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@bracyw bracyw merged commit 0532c39 into develop Nov 22, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Client] - charging screen faults are not accurate
2 participants