Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charybdis Setup #264

Merged
merged 9 commits into from
Jan 16, 2025
Merged

Charybdis Setup #264

merged 9 commits into from
Jan 16, 2025

Conversation

Peyton-McKee
Copy link
Contributor

Changes

Charybdis 2.0 Initial Setup

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No package-lock.json changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes # (issue #)

@Peyton-McKee Peyton-McKee requested review from jr1221 and bracyw January 14, 2025 20:30
@Peyton-McKee Peyton-McKee self-assigned this Jan 14, 2025
jr1221
jr1221 previously approved these changes Jan 15, 2025
Copy link
Contributor

@jr1221 jr1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bracyw bracyw assigned Peyton-McKee and unassigned Peyton-McKee Jan 16, 2025
bracyw
bracyw previously approved these changes Jan 16, 2025
Copy link
Contributor

@bracyw bracyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Peyton-McKee Peyton-McKee merged commit 28dffa1 into develop Jan 16, 2025
4 checks passed
@Peyton-McKee Peyton-McKee deleted the charybdis-2.0-setup branch January 16, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants