Run Note Endpoint #265
Merged
Run Note Endpoint #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinsoto
changed the title
…n with notes. The route now requires input for the driver, location, and notes.
bracyw
requested changes
Jan 21, 2025
scylla-server/src/main.rs
Outdated
| @@ -247,6 +247,11 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> { | |||
| .route("/runs", get(run_controller::get_all_runs)) | |||
| .route("/runs/{id}", get(run_controller::get_run_by_id)) | |||
| .route("/runs/new", post(run_controller::new_run)) | |||
| .route("/runs/new/{driver}/{location}/{notes}", post(run_controller::new_run_with_data)) | |||
| .route( | |||
| "/runs/update/{id}/{notes}", | |||
There was a problem hiding this comment.
update should probably take driver and location as well... just in case we ever want to change that. I was thinking location could be used for something like testing in different areas... not just the general test day location. Unless Jack said otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…run note
Changes
Explanation of changes goes here
Notes
Any other notes go here
Test Cases
Screenshots
If you made UI changes you must post a screenshot of the whole page for each change in 1) a normal sized window and 2) the smallest possible window
If you did any manual testing (e.g., with Postman), put screenshots of the http request and before and after of the db
If none of this applies, you can delete this section
To Do
Any remaining things that need to get done
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
package-lock.jsonchanges (unless dependencies have changed)Closes #248